Etapa 5 completa.
Some checks failed
/ Deploy to Cloudflare Pages (push) Has been cancelled

This commit is contained in:
2026-07-07 10:32:02 -03:00
parent bc9f70419c
commit ef9ec472d5
9 changed files with 511 additions and 15 deletions

View File

@@ -0,0 +1,141 @@
/**
* Tests de renderizado condicional en LibraryPage según el rol del usuario.
* Verifica que el botón "Importar BPMN" y el panel de grupos se muestran
* solo para roles internos (platform_admin / member).
*/
import { describe, it, expect, vi, beforeEach } from 'vitest'
import { render, screen } from '@testing-library/react'
import React from 'react'
// ─── Referencias mutables para controlar el rol durante los tests ─────────────
const { authUserRef, libStoreRef } = vi.hoisted(() => {
const authUserRef = {
current: {
id: 'user-1',
email: 'test@test.com',
name: 'Test User',
platformRole: 'platform_admin' as string,
},
}
const sampleProcess = {
id: 'proc-1',
name: 'Proceso de prueba',
ownerId: 'user-1',
ownerName: 'Test User',
updaterName: 'Test User',
groupId: null,
tags: [],
updatedAt: Date.now(),
bpmnXml: '',
annualFrequency: 1,
analysisHorizonYears: 3,
automationInvestment: 0,
currency: 'USD',
clientName: null,
overhead: 0,
isShared: false,
}
const sampleGroup = {
id: 'grp-1',
processId: 'proc-1',
name: 'Banca',
createdAt: Date.now(),
ownerId: 'user-1',
}
const libStoreRef = {
groups: [sampleGroup],
processes: [sampleProcess],
settings: { groupLabel: 'Área', groupLabelPlural: 'Áreas', currency: 'USD' },
isLoading: false,
error: null,
load: vi.fn(),
createGroup: vi.fn(),
getAllTags: vi.fn().mockReturnValue([]),
getLatestSimulation: vi.fn().mockResolvedValue(null),
deleteProcess: vi.fn(),
}
return { authUserRef, libStoreRef }
})
vi.mock('@/auth/AuthContext', () => ({
useAuth: () => ({ user: authUserRef.current }),
}))
vi.mock('@/store/library-store', () => ({
useLibraryStore: (selector?: (s: typeof libStoreRef) => unknown) =>
selector ? selector(libStoreRef) : libStoreRef,
}))
vi.mock('@/components/AppHeader', () => ({ AppHeader: () => null }))
vi.mock('@tanstack/react-router', () => ({
useNavigate: () => vi.fn(),
Link: ({ children }: { children: React.ReactNode }) => <>{children}</>,
}))
vi.mock('@/components/ui/use-toast', () => ({
useToast: () => ({ message: null, show: vi.fn() }),
}))
// Importar después de los mocks
import { LibraryPage } from '@/features/library/LibraryPage'
// ─── Tests ────────────────────────────────────────────────────────────────────
describe('LibraryPage — visibilidad de controles según rol', () => {
beforeEach(() => {
vi.clearAllMocks()
libStoreRef.load = vi.fn()
libStoreRef.getAllTags = vi.fn().mockReturnValue([])
libStoreRef.getLatestSimulation = vi.fn().mockResolvedValue(null)
})
describe('platform_admin', () => {
beforeEach(() => {
authUserRef.current = { ...authUserRef.current, platformRole: 'platform_admin' }
})
it('muestra el botón "Importar BPMN"', () => {
render(<LibraryPage />)
expect(screen.getByText('Importar BPMN')).toBeInTheDocument()
})
it('muestra el panel de grupos (header de sección)', () => {
render(<LibraryPage />)
expect(screen.getByTestId('groups-header')).toBeInTheDocument()
})
})
describe('client_editor', () => {
beforeEach(() => {
authUserRef.current = { ...authUserRef.current, platformRole: 'client_editor' }
})
it('NO muestra el botón "Importar BPMN"', () => {
render(<LibraryPage />)
expect(screen.queryByText('Importar BPMN')).not.toBeInTheDocument()
})
it('NO muestra el panel de grupos', () => {
render(<LibraryPage />)
expect(screen.queryByTestId('groups-header')).not.toBeInTheDocument()
})
})
describe('client_viewer', () => {
beforeEach(() => {
authUserRef.current = { ...authUserRef.current, platformRole: 'client_viewer' }
})
it('NO muestra el botón "Importar BPMN"', () => {
render(<LibraryPage />)
expect(screen.queryByText('Importar BPMN')).not.toBeInTheDocument()
})
it('NO muestra el panel de grupos', () => {
render(<LibraryPage />)
expect(screen.queryByTestId('groups-header')).not.toBeInTheDocument()
})
})
})

View File

@@ -279,6 +279,10 @@ vi.mock('@tanstack/react-router', async (importActual) => {
}
})
vi.mock('@/auth/AuthContext', () => ({
useAuth: () => ({ user: { id: 'test-user', platformRole: 'platform_admin' } }),
}))
describe('ReportPage — empty state (sin simulación)', () => {
beforeEach(() => {
vi.mocked(useReportData).mockReturnValue({

View File

@@ -47,6 +47,10 @@ vi.mock('@tanstack/react-router', async (importActual) => {
}
})
vi.mock('@/auth/AuthContext', () => ({
useAuth: () => ({ user: { id: 'test-user', platformRole: 'platform_admin' } }),
}))
// ─── Fixtures ─────────────────────────────────────────────────────────────────
import type { ActivitySimResult, Activity, SimulationResult } from '@/domain/types'

View File

@@ -0,0 +1,99 @@
/**
* Tests de guards de rol para rutas protegidas.
* Verifica las condiciones de redirección para client_viewer e client_editor.
*/
import { describe, it, expect } from 'vitest'
import type { AuthUser } from '@/auth/types'
// ─── Helper: construir un usuario de prueba con un rol específico ──────────────
function makeUser(platformRole: AuthUser['platformRole']): AuthUser {
return {
id: 'user-test',
email: 'test@test.com',
name: 'Test User',
platformRole,
}
}
// ─── Guard de workspace: client_viewer → redirige a /report/$processId ────────
function workspaceGuardShouldRedirect(user: AuthUser | null): boolean {
return user?.platformRole === 'client_viewer'
}
describe('workspace route guard', () => {
it('client_viewer debe redirigir al reporte', () => {
expect(workspaceGuardShouldRedirect(makeUser('client_viewer'))).toBe(true)
})
it('client_editor NO debe redirigir', () => {
expect(workspaceGuardShouldRedirect(makeUser('client_editor'))).toBe(false)
})
it('platform_admin NO debe redirigir', () => {
expect(workspaceGuardShouldRedirect(makeUser('platform_admin'))).toBe(false)
})
it('member NO debe redirigir', () => {
expect(workspaceGuardShouldRedirect(makeUser('member'))).toBe(false)
})
it('usuario null NO debe redirigir (no autenticado)', () => {
expect(workspaceGuardShouldRedirect(null)).toBe(false)
})
})
// ─── Guard de importación: solo platform_admin y member pueden importar ────────
function importGuardShouldRedirect(user: AuthUser | null): boolean {
if (!user) return false // RootComponent maneja el redirect a /login
const allowed: AuthUser['platformRole'][] = ['platform_admin', 'member']
return !allowed.includes(user.platformRole)
}
describe('import route guard', () => {
it('client_editor debe redirigir a /', () => {
expect(importGuardShouldRedirect(makeUser('client_editor'))).toBe(true)
})
it('client_viewer debe redirigir a /', () => {
expect(importGuardShouldRedirect(makeUser('client_viewer'))).toBe(true)
})
it('guest debe redirigir a /', () => {
expect(importGuardShouldRedirect(makeUser('guest'))).toBe(true)
})
it('platform_admin NO debe redirigir', () => {
expect(importGuardShouldRedirect(makeUser('platform_admin'))).toBe(false)
})
it('member NO debe redirigir', () => {
expect(importGuardShouldRedirect(makeUser('member'))).toBe(false)
})
})
// ─── Cálculo de tab por defecto en ReportPage ─────────────────────────────────
function computeDefaultTab(user: AuthUser | null): 'actual' | 'roi' {
return user?.platformRole === 'client_viewer' ? 'roi' : 'actual'
}
describe('ReportPage defaultTab', () => {
it('client_viewer arranca en tab ROI', () => {
expect(computeDefaultTab(makeUser('client_viewer'))).toBe('roi')
})
it('platform_admin arranca en tab actual', () => {
expect(computeDefaultTab(makeUser('platform_admin'))).toBe('actual')
})
it('client_editor arranca en tab actual', () => {
expect(computeDefaultTab(makeUser('client_editor'))).toBe('actual')
})
it('member arranca en tab actual', () => {
expect(computeDefaultTab(makeUser('member'))).toBe('actual')
})
})