Some checks failed
/ Deploy to Cloudflare Pages (push) Has been cancelled
Fix A1 — isProfileLoaded en AuthContext ✅ useState(false) inicial setIsProfileLoaded(true) si onAuthStateChange devuelve null (no hay usuario que sincronizar) setIsProfileLoaded(false) en SIGNED_IN (resetea para el nuevo sync) setIsProfileLoaded(true) en el finally del sync effect (después de syncProfileFromDB, éxito o error) Fix A2 — Guard en LibraryPage ✅ if (!user || !isProfileLoaded) devuelve skeleton animado antes de cualquier contenido rol-dependiente Fix A3 — Campo "cliente" read-only para client_editor ✅ GlobalSettingsPanel.tsx: <p> estático en lugar de <Input> cuando isClientRole WorkspacePage.tsx: topbar muestra el valor sin input ni lápiz para client_editor Fix B — Migración 016 + aplicada a DB ✅ Archivo supabase/migrations/016_add_simulations_update_policy.sql creado Policy simulations_update confirmada activa en DB (pg_policies devuelve las 4 policies de simulations) Fix adicional — 403 en POST /processes ✅ (ejecutado en el turno inmediato anterior) updateEditable() en process-repo.ts usa .update() en lugar de .upsert() para todos los paths de edición Tests: 586 verdes, build limpio. Lo que falta según el checklist del prompt es la validación visual del director (msebem@gmail.com en la app real). Eso requiere tu OK después de verificar en el navegador. domain/types.ts — orgId: string | null agregado a Process (campo de DB ya existente, ahora mapeado en el dominio). process-repo.ts — fromRow incluye orgId: (row.org_id as string | null) ?? null. Ambas queries (getById y getAll) usan select('*'), por lo que el campo viene gratis. WorkspacePage.tsx: Import supabase para el fetch de org name Estado orgName + useEffect que hace SELECT name FROM organizations WHERE id = orgId cuando cambia currentProcess?.orgId Variable isClientRole (solo client_editor — client_viewer ya fue redirigido) backLabel: "Procesos" para client_editor, nombre de org (o "Volver" mientras carga) si hay orgId, "Biblioteca" si no hay handleBack(): navega a /?org=<orgId> para admin con proceso de cliente, a / para el resto El Home button + Tooltip fueron reemplazados por <Button variant="ghost" size="sm"> con ArrowLeft + backLabel LibraryPage.tsx: Import useSearch Lee orgParam = useSearch({ from: '/' }) as { org?: string } useEffect que, cuando orgParam está presente y la carga terminó, busca el proceso con p.orgId === orgParam, obtiene su groupId, y hace scrollIntoView al elemento group-{groupId} Los GroupCards en el grid están ahora envueltos en <div id="group-{group.id}"> para ser alcanzables por el scroll Tests — workspace-back-button.test.ts con 6 casos: admin+orgName, admin+orgName loading, admin sin org, member sin org, client_editor, client_viewer. Fixtures actualizados en 13 archivos con orgId: null. Mock de useSearch agregado en library-ui.test.tsx.
222 lines
11 KiB
TypeScript
222 lines
11 KiB
TypeScript
import { describe, it, expect } from 'vitest'
|
||
import { generateCsvContent } from '@/lib/export/csv-export'
|
||
import type { Process, Simulation, Resource, SimulationResult } from '@/domain/types'
|
||
|
||
// ─── Fixtures ─────────────────────────────────────────────────────────────────
|
||
|
||
function makeProcess(currency: string, extras: Partial<Process> = {}): Process {
|
||
return {
|
||
id: 'p1', name: 'Proceso de Ventas', clientName: 'Empresa ABC',
|
||
bpmnXml: '', currency, overheadPercentage: 0.2,
|
||
annualFrequency: 1000, analysisHorizonYears: 3, automationInvestment: 0,
|
||
createdAt: 0, updatedAt: 0, groupId: null, tags: [], ownerId: 'test-user', updatedBy: 'test-user', orgId: null, ...extras,
|
||
}
|
||
}
|
||
|
||
function makeSimulation(perActivity: SimulationResult['perActivity'] = []): Simulation {
|
||
const totalDirect = perActivity.reduce((s, a) => s + a.expectedDirectCost, 0)
|
||
const totalIndirect = perActivity.reduce((s, a) => s + a.expectedIndirectCost, 0)
|
||
return {
|
||
id: 'sim1', processId: 'p1',
|
||
executedAt: new Date('2026-05-13T10:00:00Z').getTime(),
|
||
result: {
|
||
totalCost: totalDirect + totalIndirect,
|
||
totalDirectCost: totalDirect,
|
||
totalIndirectCost: totalIndirect,
|
||
totalTimeMinutes: 90,
|
||
perActivity,
|
||
perResource: [],
|
||
warnings: [],
|
||
},
|
||
}
|
||
}
|
||
|
||
const mockActivities: SimulationResult['perActivity'] = [
|
||
{
|
||
activityId: 'a1', bpmnElementId: 'task1', activityName: 'Recibir solicitud',
|
||
expectedDirectCost: 500, expectedIndirectCost: 100, expectedTotalCost: 600,
|
||
percentOfTotal: 60, executionProbability: 1.0, expectedExecutions: 1.0,
|
||
executionTimeMinutes: 30, resourceCostBreakdown: [],
|
||
},
|
||
{
|
||
activityId: 'a2', bpmnElementId: 'task2', activityName: 'Análisis de crédito',
|
||
expectedDirectCost: 250, expectedIndirectCost: 50, expectedTotalCost: 300,
|
||
percentOfTotal: 30, executionProbability: 0.8, expectedExecutions: 0.8,
|
||
executionTimeMinutes: 60, resourceCostBreakdown: [],
|
||
},
|
||
{
|
||
activityId: 'a3', bpmnElementId: 'task3', activityName: 'Notificación al cliente',
|
||
expectedDirectCost: 83.33, expectedIndirectCost: 16.67, expectedTotalCost: 100,
|
||
percentOfTotal: 10, executionProbability: 0.5, expectedExecutions: 0.5,
|
||
executionTimeMinutes: 15, resourceCostBreakdown: [],
|
||
},
|
||
]
|
||
|
||
const resources: Resource[] = []
|
||
|
||
// ─── BOM UTF-8 ────────────────────────────────────────────────────────────────
|
||
describe('CSV — BOM UTF-8', () => {
|
||
it('comienza con BOM UTF-8 (\\uFEFF)', () => {
|
||
const csv = generateCsvContent({ process: makeProcess('USD'), simulation: makeSimulation(mockActivities), resources })
|
||
expect(csv.charCodeAt(0)).toBe(0xFEFF)
|
||
})
|
||
|
||
it('BOM está presente para PYG también', () => {
|
||
const csv = generateCsvContent({ process: makeProcess('PYG'), simulation: makeSimulation(mockActivities), resources })
|
||
expect(csv.charCodeAt(0)).toBe(0xFEFF)
|
||
})
|
||
})
|
||
|
||
// ─── Separadores ──────────────────────────────────────────────────────────────
|
||
describe('CSV — separadores', () => {
|
||
it('USD: separador de columnas es coma ","', () => {
|
||
const csv = generateCsvContent({ process: makeProcess('USD'), simulation: makeSimulation(mockActivities), resources })
|
||
// Los headers deben estar separados por coma
|
||
const headerLine = csv.split('\r\n').find((l) => l.includes('Actividad'))!
|
||
expect(headerLine).toContain(',')
|
||
expect(headerLine).not.toContain(';')
|
||
})
|
||
|
||
it('PYG: separador de columnas es punto y coma ";"', () => {
|
||
const csv = generateCsvContent({ process: makeProcess('PYG'), simulation: makeSimulation(mockActivities), resources })
|
||
const headerLine = csv.split('\r\n').find((l) => l.includes('Actividad'))!
|
||
expect(headerLine).toContain(';')
|
||
expect(headerLine).not.toContain(',"Actividad"')
|
||
})
|
||
|
||
it('BRL: separador es punto y coma', () => {
|
||
const csv = generateCsvContent({ process: makeProcess('BRL'), simulation: makeSimulation(mockActivities), resources })
|
||
const headerLine = csv.split('\r\n').find((l) => l.includes('Actividad'))!
|
||
expect(headerLine).toContain(';')
|
||
})
|
||
|
||
it('EUR: separador es punto y coma', () => {
|
||
const csv = generateCsvContent({ process: makeProcess('EUR'), simulation: makeSimulation(mockActivities), resources })
|
||
const headerLine = csv.split('\r\n').find((l) => l.includes('Actividad'))!
|
||
expect(headerLine).toContain(';')
|
||
})
|
||
})
|
||
|
||
// ─── Separadores decimales ─────────────────────────────────────────────────────
|
||
describe('CSV — separadores decimales', () => {
|
||
it('USD: decimal es punto "." → "500.00"', () => {
|
||
const csv = generateCsvContent({ process: makeProcess('USD'), simulation: makeSimulation(mockActivities), resources })
|
||
expect(csv).toContain('500.00')
|
||
})
|
||
|
||
it('PYG: decimal es coma "," → "500,00"', () => {
|
||
const csv = generateCsvContent({ process: makeProcess('PYG'), simulation: makeSimulation(mockActivities), resources })
|
||
expect(csv).toContain('500,00')
|
||
})
|
||
|
||
it('BRL: decimal es coma', () => {
|
||
const csv = generateCsvContent({ process: makeProcess('BRL'), simulation: makeSimulation(mockActivities), resources })
|
||
expect(csv).toContain('500,00')
|
||
})
|
||
})
|
||
|
||
// ─── Headers ──────────────────────────────────────────────────────────────────
|
||
describe('CSV — headers', () => {
|
||
it('contiene "Actividad" en los headers', () => {
|
||
const csv = generateCsvContent({ process: makeProcess('USD'), simulation: makeSimulation(mockActivities), resources })
|
||
expect(csv).toContain('Actividad')
|
||
})
|
||
|
||
it('header de costo incluye la moneda: "Costo total (USD)"', () => {
|
||
const csv = generateCsvContent({ process: makeProcess('USD'), simulation: makeSimulation(mockActivities), resources })
|
||
expect(csv).toContain('Costo total (USD)')
|
||
})
|
||
|
||
it('header de costo incluye la moneda: "Costo total (PYG)"', () => {
|
||
const csv = generateCsvContent({ process: makeProcess('PYG'), simulation: makeSimulation(mockActivities), resources })
|
||
expect(csv).toContain('Costo total (PYG)')
|
||
})
|
||
|
||
it('contiene todos los headers requeridos', () => {
|
||
const csv = generateCsvContent({ process: makeProcess('USD'), simulation: makeSimulation(mockActivities), resources })
|
||
expect(csv).toContain('ID BPMN')
|
||
expect(csv).toContain('Tiempo (min)')
|
||
expect(csv).toContain('% del total')
|
||
expect(csv).toContain('Ejecuciones esperadas')
|
||
expect(csv).toContain('Recursos asignados')
|
||
})
|
||
})
|
||
|
||
// ─── Cantidad de filas ────────────────────────────────────────────────────────
|
||
describe('CSV — cantidad de filas', () => {
|
||
it('tiene exactamente N filas de datos + header + metadata', () => {
|
||
const csv = generateCsvContent({ process: makeProcess('USD'), simulation: makeSimulation(mockActivities), resources })
|
||
// Quitar BOM antes de procesar para no confundir el filtro de comentarios
|
||
const csvNoBom = csv.startsWith('') ? csv.slice(1) : csv
|
||
const lines = csvNoBom.split('\r\n').filter((l) => l.trim() && !l.startsWith('#'))
|
||
// 1 header + N actividades
|
||
expect(lines).toHaveLength(mockActivities.length + 1)
|
||
})
|
||
|
||
it('0 actividades → solo header', () => {
|
||
const csv = generateCsvContent({ process: makeProcess('USD'), simulation: makeSimulation([]), resources })
|
||
const csvNoBom = csv.startsWith('') ? csv.slice(1) : csv
|
||
const lines = csvNoBom.split('\r\n').filter((l) => l.trim() && !l.startsWith('#'))
|
||
expect(lines).toHaveLength(1) // solo el header
|
||
})
|
||
})
|
||
|
||
// ─── Metadata de cabecera ─────────────────────────────────────────────────────
|
||
describe('CSV — metadata', () => {
|
||
it('la metadata comienza con "# Proceso:"', () => {
|
||
const csv = generateCsvContent({ process: makeProcess('USD'), simulation: makeSimulation(mockActivities), resources })
|
||
expect(csv).toContain('# Proceso: Proceso de Ventas')
|
||
})
|
||
|
||
it('la metadata contiene el nombre del cliente', () => {
|
||
const csv = generateCsvContent({ process: makeProcess('USD'), simulation: makeSimulation(mockActivities), resources })
|
||
expect(csv).toContain('# Cliente: Empresa ABC')
|
||
})
|
||
|
||
it('la metadata contiene el costo total', () => {
|
||
const csv = generateCsvContent({ process: makeProcess('USD'), simulation: makeSimulation(mockActivities), resources })
|
||
expect(csv).toContain('# Costo total (USD)')
|
||
})
|
||
})
|
||
|
||
// ─── Caracteres especiales / UTF-8 ───────────────────────────────────────────
|
||
describe('CSV — UTF-8 y caracteres especiales', () => {
|
||
it('nombres con acentos se preservan correctamente', () => {
|
||
const activitiesWithAccents: SimulationResult['perActivity'] = [{
|
||
activityId: 'a1', bpmnElementId: 't1',
|
||
activityName: 'Revisión y Análisis Crítico',
|
||
expectedDirectCost: 100, expectedIndirectCost: 20, expectedTotalCost: 120,
|
||
percentOfTotal: 100, executionProbability: 1, expectedExecutions: 1,
|
||
executionTimeMinutes: 30, resourceCostBreakdown: [],
|
||
}]
|
||
const csv = generateCsvContent({ process: makeProcess('USD'), simulation: makeSimulation(activitiesWithAccents), resources })
|
||
expect(csv).toContain('Revisión y Análisis Crítico')
|
||
})
|
||
|
||
it('nombre del proceso con ñ se preserva', () => {
|
||
const process = makeProcess('USD', { name: 'Gestión de la Compañía' })
|
||
const csv = generateCsvContent({ process, simulation: makeSimulation([]), resources })
|
||
expect(csv).toContain('Gestión de la Compañía')
|
||
})
|
||
|
||
it('actividad con nombre en blanco no rompe el CSV', () => {
|
||
const activitiesBlank: SimulationResult['perActivity'] = [{
|
||
activityId: 'a1', bpmnElementId: 't1', activityName: '',
|
||
expectedDirectCost: 0, expectedIndirectCost: 0, expectedTotalCost: 0,
|
||
percentOfTotal: 0, executionProbability: 1, expectedExecutions: 1,
|
||
executionTimeMinutes: 0, resourceCostBreakdown: [],
|
||
}]
|
||
expect(() => generateCsvContent({ process: makeProcess('USD'), simulation: makeSimulation(activitiesBlank), resources })).not.toThrow()
|
||
})
|
||
})
|
||
|
||
// ─── Recursos vacíos ──────────────────────────────────────────────────────────
|
||
describe('CSV — recursos vacíos', () => {
|
||
it('actividad sin recursos → celda de recursos vacía (no rompe)', () => {
|
||
const csv = generateCsvContent({ process: makeProcess('USD'), simulation: makeSimulation(mockActivities), resources: [] })
|
||
// No debe crashear y el contenido es válido
|
||
expect(csv.length).toBeGreaterThan(0)
|
||
expect(csv).toContain('Recibir solicitud')
|
||
})
|
||
})
|